Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload sarif for eslint results #2469

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Upload sarif for eslint results #2469

merged 3 commits into from
Sep 10, 2024

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Sep 9, 2024 •
edited
Loading

This change will upload the eslint results as sarif to code scanning during the CI process.

Merge / deployment checklist

  • [n/a] Confirm this change is backwards compatible with existing workflows.
  • [n/a] Confirm the readme has been updated if necessary.
  • [n/a] Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner September 9, 2024 20:16
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@aeisenberg
Copy link
Contributor Author

It's surprising to me that code scanning is showing a bunch of alerts even though when run locally, they don't appear.

https://github.com/github/codeql-action/security/code-scanning?query=pr%3A2469+is%3Aopen

It looks like the sarif formatter is including alerts that are disabled by eslint-disable-next-line.

rvermeulen
rvermeulen previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@rvermeulen rvermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once the test are passing we are good to :shipit:

@aeisenberg aeisenberg merged commit e817992 into main Sep 10, 2024
312 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/upload-eslint-sarif branch September 10, 2024 22:51
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Merged
8 tasks
@dbartol dbartol mentioned this pull request Sep 13, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvermeulen rvermeulen rvermeulen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeisenberg @rvermeulen